Fix URL opening action on iOS (#6384)

4ian · Feb 26, 2024 · e345b27 · e345b27
1 parent 3a2a662
commit e345b27
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 3 deletions.
diff --git a/GDJS/GDJS/Extensions/Builtin/NetworkExtension.cpp b/GDJS/GDJS/Extensions/Builtin/NetworkExtension.cpp
@@ -25,6 +25,11 @@ NetworkExtension::NetworkExtension() {
       "gdjs.evtTools.network.enableMetrics");
   GetAllActions()["LaunchFile"].SetFunctionName("gdjs.evtTools.window.openURL");
 
+  AddDependency()
+      .SetName("InAppBrowser Cordova plugin")
+      .SetDependencyType("cordova")
+      .SetExportName("cordova-plugin-inappbrowser");
+
   StripUnimplementedInstructionsAndExpressions();
 }
 

diff --git a/GDJS/Runtime/pixi-renderers/runtimegame-pixi-renderer.ts b/GDJS/Runtime/pixi-renderers/runtimegame-pixi-renderer.ts
@@ -859,10 +859,16 @@ namespace gdjs {
         const electron = this.getElectron();
         if (electron) {
           electron.shell.openExternal(url);
-        } else {
+        } else if (
+          // @ts-ignore
+          typeof window.cordova !== 'undefined' &&
           // @ts-ignore
-          const target = window.cordova ? '_system' : '_blank';
-          window.open(url, target);
+          typeof window.cordova.InAppBrowser !== 'undefined'
+        ) {
+          // @ts-ignore
+          window.cordova.InAppBrowser.open(url, '_system', 'location=yes');
+        } else {
+          window.open(url, '_blank');
         }
       }
     }