Skip to content

Commit

Permalink
Add a log if the effect doesn't exist
Browse files Browse the repository at this point in the history
  • Loading branch information
D8H committed Dec 4, 2023
1 parent 5a46cc7 commit eedf908
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 0 deletions.
11 changes: 11 additions & 0 deletions Extensions/TweenBehavior/tweenruntimebehavior.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ GDevelop - Tween Behavior Extension
Copyright (c) 2010-2023 Florian Rival ([email protected])
*/
namespace gdjs {
const logger = new gdjs.Logger('Tween');
interface IColorable extends gdjs.RuntimeObject {
setColor(color: string): void;
getColor(): string;
Expand Down Expand Up @@ -948,6 +949,11 @@ namespace gdjs {
destroyObjectWhenFinished: boolean
) {
const effect = this.owner.getRendererEffects()[effectName];
if (!effect) {
logger.error(
`The object "${this.owner.name}" doesn't have any effect called "${effectName}"`
);
}
this._tweens.addSimpleTween(
identifier,
this.owner,
Expand Down Expand Up @@ -987,6 +993,11 @@ namespace gdjs {
destroyObjectWhenFinished: boolean
) {
const effect = this.owner.getRendererEffects()[effectName];
if (!effect) {
logger.error(
`The object "${this.owner.name}" doesn't have any effect called "${effectName}"`
);
}
const rgbFromColor = gdjs.hexNumberToRGB(
effect ? effect.getColorParameter(propertyName) : 0
);
Expand Down
12 changes: 12 additions & 0 deletions Extensions/TweenBehavior/tweentools.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ namespace gdjs {
}
export namespace evtTools {
export namespace tween {
const logger = new gdjs.Logger('Tween');

export const getTweensMap = (runtimeScene: RuntimeScene) =>
runtimeScene._tweens ||
(runtimeScene._tweens = new gdjs.evtTools.tween.TweenManager());
Expand Down Expand Up @@ -503,6 +505,11 @@ namespace gdjs {
) => {
const layer = runtimeScene.getLayer(layerName);
const effect = layer.getRendererEffects()[effectName];
if (!effect) {
logger.error(
`The layer "${layer.getName()}" doesn't have any effect called "${effectName}"`
);
}
getTweensMap(runtimeScene).addSimpleTween(
identifier,
layer,
Expand Down Expand Up @@ -542,6 +549,11 @@ namespace gdjs {
) => {
const layer = runtimeScene.getLayer(layerName);
const effect = layer.getRendererEffects()[effectName];
if (!effect) {
logger.error(
`The layer "${layer.getName()}" doesn't have any effect called "${effectName}"`
);
}
const rgbFromColor = gdjs.hexNumberToRGB(
effect ? effect.getColorParameter(propertyName) : 0
);
Expand Down

0 comments on commit eedf908

Please sign in to comment.