Automatically fix object/group/function/behavior/object/property names when an incorrect one is entered #5561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Also for scenes, external events, external layouts and extensions in the project manager.
…rs and their properties
4ian
changed the title
D8H
reviewed
Aug 14, 2023
Comment on lines
+1017
to
+1020
| // Replace all unallowed letters by an underscore. | ||
| if (allowedCharacters.find_first_of(std::u32string(1, newName[i])) == gd::String::npos) { | ||
| newName.replace(i, 1, '_'); | ||
| } |
There was a problem hiding this comment.
What if none of the characters are safe?
Should the renaming be aboorted rather than using _______?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And also for scenes, external events, external layouts and extensions in the project manager.
This removes all the "flow breaking" message boxes. While this might make the reason for the renaming harder to understand, I think it will be well understood. For example in Figma, if you rename a shape to an empty string, it will override it with a default name.
In the future, we could show a snack bar at the bottom that gives an explanation, but not even sure it's required (could be added in the docs, and that's it - the important is that GDevelop fixes the name for you).
Fix #5557