Remember collapsed state of object behaviors #5641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4ian
reviewed
Sep 7, 2023
Comment on lines
107
to
112
| React.useEffect( | ||
| () => { | ||
| behavior.setFolded(!expanded); | ||
| }, | ||
| [expanded, behavior] | ||
| ); |
There was a problem hiding this comment.
Why do you need this effect and a state? Why not using behavior.isFolded()/behavior.setFolded (and a forceUpdate when you update it)?
4ian
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5562
I checked no extension has a behavior with a property=> not necessary anymore since we don't save the collapsed state in the projectfolded.As discussed together, the collapsed state is not saved in the project to avoid polluting the behavior state with a UI consideration.
So each time the project is reopened, behavior panels will be uncollapsed.