Implement spine extension #5927

f0nar · 2023-11-20T15:56:16Z

Implementation of 5775 issue

I took responsibility to introduce spine to GDevelop. This PR implements base features such as animations playing and switching, time scaling and auto update.

From known improvement and TODOs I want to add skin support and update spine object configuration panel with autofilling of atlas and image files paths. But let's take our time with this, because there are already quite a lot of changes here.

I am interested in this functionality so I will be grateful for assistance and comments.

…on, action to spine object

…f incorrect spine files used

D8H · 2024-01-15T19:12:47Z

Changes

Replace actions, condition and expressions with the one of capabilities
- It allows extensions for sprites and 3D models to work with Spines
- The animation mixing duration is in its own action because the Animatable doesn't has this feature.
  - I wonder if users should be allowed to set a default value globally or on each animation in the Spine object editor.
- Add actions for animation time control
- Add flip actions
Remove the time scale property. In the future, animations duration could be customized one by one (like for sprites).
Handle scene and layer time scale

I used this project to test the capabilities:
capabilities.zip
https://gd.games/instant-builds/47ad8ca7-d7bf-4ca4-9abd-b2c30cc861af?dev=true

D8H · 2024-01-15T19:17:09Z

Extensions/Spine/SpineObjectConfiguration.h

+
+private:
+  double scale;
+  double opacity;


I guess the opacity property could be removed. Especially because the transparency doesn't render correctly. The object parts are blending into each other which make them less transparent.

I went ahead and removed the opacity property too, but in its own commit so it's easy to create a revert commit.

D8H · 2024-01-15T19:23:40Z

In the case you are already using your extension, you can use this setting to update your project:

I kept most of the actions and only hidden them (for now) to let you update your project more easily.

f0nar · 2024-01-16T09:25:20Z

Remove the time scale property. In the future, animations duration could be customized one by one (like for sprites).

@D8H can we remove it when it is the case?

D8H · 2024-01-16T09:28:06Z

Remove the time scale property. In the future, animations duration could be customized one by one (like for sprites).

@D8H can we remove it when it is a case?

Properties can never be removed for compatibility reason. This is why in case there is a doubt, it's better not to add them.

D8H · 2024-01-17T09:09:04Z

Extensions/Spine/JsExtension.js

+    // TODO Remove before the release.
+    object
+      .addExpressionAndConditionAndAction(


I'll actually remove the old actions before the merge.

D8H · 2024-01-17T11:37:54Z

I removed the old actions. Please keep your branch to update your projects from the previous commit if you need to.

D8H

LGTM, thank you for this extension, it looks really cool!

LousyMolars · 2024-01-17T15:02:33Z

Hey, @4ian, I have added new Spine demo to replace this abomination. New issue is here - GDevelopApp/GDevelop-examples#620

I'm planning on maintaining this project in the future, to test and apply new features for Spine object. Not sure if I followed all best practices, game became larger than anticipated. If someone can check project for mistakes, I'm willing to fix or completely redo weak parts.
Some art and sound was generated by neural networks, other was taken from cc0 sources without need for attribution.

Online version https://gd.games/lousymolars/calcopus

4ian

Let's go!

4ian · 2024-01-17T17:21:29Z

And this is finally merged! I'm stocked to see this available for the next GDevelop release which should be ready in a few days :)

Many thanks @f0nar and @LousyMolars for your work here, including the various follow ups and examples.

Online version https://gd.games/lousymolars/calcopus

This looks awesome!

I'm planning on maintaining this project in the future, to test and apply new features for Spine object.

We're more than happy to have you continue improving it and maintaining it - the more we have contributors making real world usage of the various GDevelop extensions, the better we ensure they are maintained and up to date.

Thanks again, that's one of the biggest feature we got from new contributors recently 👏
I think the quality of the result is very high (thanks @D8H for implementing the latest "capability" features).

f0nar · 2024-01-17T18:09:21Z

@4ian and @D8H many thanks for your comments, support and fixes. I am glad to be part of this project. Looking forward for release!
I believe that I will meet many interesting tasks and improvements here

Onnevan · 2024-03-01T10:19:37Z

Great to see Spine implemented in GDevelop, thank you @f0nar for your work. Do you have any info on how to use it? because when I tried to use it with default export options in Spine I get an error stating the spine file doesn't find the name of the Atlas. I've tried different things, like renaming the .atlas to .txt and other settings but with no luck. Thanks!

f0nar · 2024-03-01T13:29:39Z

@Onnevan are you working from desktop version? Spine functionality is available there only

LousyMolars · 2024-03-01T13:33:12Z

Great to see Spine implemented in GDevelop, thank you @f0nar for your work. Do you have any info on how to use it? because when I tried to use it with default export options in Spine I get an error stating the spine file doesn't find the name of the Atlas. I've tried different things, like renaming the .atlas to .txt and other settings but with no luck. Thanks!

Hey. Can you maybe share your export file or error in details? Spine 4.0 or 4.1 should work. Here are export settings that worked for me:

Project where you can check events and object - GDevelopApp/GDevelop-examples#620

We didn't test if extension works with "essential" version, only "pro", maybe that could be a reason.

Onnevan · 2024-03-01T22:45:36Z

I will try again @LousyMolars and @f0nar , but I'm on desktop (Win) and have the pro version, so we can rule that out. The error is this:

I've tried with diferent files, all of them Spine examples, not my own. Also, I have Spine lisenced

f0nar · 2024-03-02T08:53:22Z

I will try again @LousyMolars and @f0nar , but I'm on desktop (Win) and have the pro version, so we can rule that out. The error is this:

I've tried with diferent files, all of them Spine examples, not my own. Also, I have Spine lisenced

Could you attach here the files you are trying to load?

Onnevan · 2024-03-02T08:57:37Z

@f0nar of course:
vine-pro.zip

Onnevan · 2024-03-02T08:59:15Z

I'm on Spine 4.1.24 professional and GDevelop 5.3.191, Windows 11

f0nar · 2024-03-02T09:06:57Z

Everything is fine for me. I am able to load spine by selecting vine-pro.json file and then play it in preview

I see that it is called vine-pro.json in archive but you have selected vine.json on screenshot. Is there any difference?
I would appreciate if you share more details on how you do that. Maybe screen record

Onnevan · 2024-03-02T09:41:18Z

@f0nar Oh, that's because I thought maybe the dash in the name was the problem (which I know has no sense) but I was just trying things. I can confirm the same error with vine-pro. It's very strange but I guess is just something on my side, I'll try whatever I can think of, like different files, directories and software versions. I'll do a screen record too

Onnevan · 2024-03-02T09:53:56Z

@f0nar nevermind, I closed everything, started a project from scratch and everything works fine! thanks for the help, don't know what could be happening. is there any doc on how to use it?. Thank you for the great work!

edit: I got tha hang of it, I was lost because I thought every behaviour related to Spine would be under a Spine component but I realized the normal animation behaviours work with it.

Vladyslav Pohorielov added 30 commits July 21, 2023 13:38

first not tested commit with spine extension and atlas resource

de2adbc

Merge branch 'master' into spine-extension

dae9cbf

implement base spine functionality, properties panel and object editor

65f370f

Merge branch 'master' into spine-extension

db3a94a

add isAnimationComplete condition and isUpdatable expression, conditi…

93903c6

…on, action to spine object

fix extension configuration

086e49f

make spine creation synchrounous in SpineRuntimeObject

476eea8

use regex to get atlas image path

6ecd04e

fix spine extension issues

88cda55

clean up code

9ed5fbc

Merge branch 'master' into spine-extension

2d20907

solve flow test errors

01c2afc

apply format

95f5474

ignore pixi-spine during check-types

e36a050

format and style code, fix some test

3477f58

remove console logs, solve typos

2313fe9

remove pixi deps

4ac52de

Merge branch 'master' into spine-extension

3628be7

update pixi-spine to 4.x.x

a6895fc

Merge branch 'master' into spine-extension

5b33a7f

copy pixi-spine.js from node_modules on postinstall

bd60956

cover errors on spine loading with incompatible files

25cdc63

remove pixi-spine import in global d.ts files, remove animations ui i…

a982540

…f incorrect spine files used

run format

b466d4d

fix flow issues

55fcf45

fix react warnings

56e940a

run format and flow

fc941b0

update spine configuration page

71333b7

update typings and docs

ee70d96

remove dev console.logs

75da727

D8H added 2 commits January 15, 2024 12:13

Add capabilities for size, scale, flip, opacity and effects.

234cbb0

Add capability for animation.

a12bcab

D8H reviewed Jan 15, 2024

View reviewed changes

Add a warning about the license.

f1d80a2

D8H added 3 commits January 16, 2024 10:31

Remove the opacity property.

5c6e285

Fix default size update on hot-reload.

35cf1cf

Update the hit-boxes while the animation plays.

c6d96ad

D8H reviewed Jan 17, 2024

View reviewed changes

Remove deprecated actions.

15442f0

D8H approved these changes Jan 17, 2024

View reviewed changes

4ian approved these changes Jan 17, 2024

View reviewed changes

4ian merged commit d0005ba into 4ian:master Jan 17, 2024
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement spine extension #5927

Implement spine extension #5927

f0nar commented Nov 20, 2023

D8H commented Jan 15, 2024 •

edited

Loading

D8H Jan 15, 2024

D8H Jan 16, 2024

D8H commented Jan 15, 2024 •

edited

Loading

f0nar commented Jan 16, 2024 •

edited

Loading

D8H commented Jan 16, 2024

D8H Jan 17, 2024

D8H commented Jan 17, 2024

D8H left a comment

LousyMolars commented Jan 17, 2024 •

edited

Loading

4ian left a comment

4ian commented Jan 17, 2024

f0nar commented Jan 17, 2024

Onnevan commented Mar 1, 2024 •

edited

Loading

f0nar commented Mar 1, 2024

LousyMolars commented Mar 1, 2024

Onnevan commented Mar 1, 2024 •

edited

Loading

f0nar commented Mar 2, 2024

Onnevan commented Mar 2, 2024 •

edited

Loading

Onnevan commented Mar 2, 2024

f0nar commented Mar 2, 2024

Onnevan commented Mar 2, 2024

Onnevan commented Mar 2, 2024 •

edited

Loading

Implement spine extension #5927

Implement spine extension #5927

Conversation

f0nar commented Nov 20, 2023

D8H commented Jan 15, 2024 • edited Loading

Changes

D8H Jan 15, 2024

Choose a reason for hiding this comment

D8H Jan 16, 2024

Choose a reason for hiding this comment

D8H commented Jan 15, 2024 • edited Loading

f0nar commented Jan 16, 2024 • edited Loading

D8H commented Jan 16, 2024

D8H Jan 17, 2024

Choose a reason for hiding this comment

D8H commented Jan 17, 2024

D8H left a comment

Choose a reason for hiding this comment

LousyMolars commented Jan 17, 2024 • edited Loading

4ian left a comment

Choose a reason for hiding this comment

4ian commented Jan 17, 2024

f0nar commented Jan 17, 2024

Onnevan commented Mar 1, 2024 • edited Loading

f0nar commented Mar 1, 2024

LousyMolars commented Mar 1, 2024

Onnevan commented Mar 1, 2024 • edited Loading

f0nar commented Mar 2, 2024

Onnevan commented Mar 2, 2024 • edited Loading

Onnevan commented Mar 2, 2024

f0nar commented Mar 2, 2024

Onnevan commented Mar 2, 2024

Onnevan commented Mar 2, 2024 • edited Loading

D8H commented Jan 15, 2024 •

edited

Loading

D8H commented Jan 15, 2024 •

edited

Loading

f0nar commented Jan 16, 2024 •

edited

Loading

LousyMolars commented Jan 17, 2024 •

edited

Loading

Onnevan commented Mar 1, 2024 •

edited

Loading

Onnevan commented Mar 1, 2024 •

edited

Loading

Onnevan commented Mar 2, 2024 •

edited

Loading

Onnevan commented Mar 2, 2024 •

edited

Loading