Replace parcel watcher with chokidar #5932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ClementPasteau
approved these changes
Nov 21, 2023
| .on('unlink', fileWiseCallback) | ||
| .on('add', fileWiseCallback); | ||
|
|
||
| subscriptionCancelers[newSubscriptionId] = () => watcher.unwatch(folderPath); |
There was a problem hiding this comment.
just to check, this function is not async?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following issues building Desktop app with parcel watcher (See #5920), this PR brings back chokidar.
It also reduces unnecessary redefinitions of the watcher.
Now editors have to register themselves in order to get the information about when a resource has been changed.
Note: It is done using
componentDidMountandcomponentWillUnmountbut it can replaced with a singleReact.useEffectwith a tidying function when the component is transformed into a functional component.