Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add game dashboard on home page and project manager #5963

Merged
merged 38 commits into from
Nov 29, 2023

Conversation

AlexandreSi
Copy link
Collaborator

@AlexandreSi AlexandreSi commented Nov 27, 2023

This PR adds a new tab on the homepage to see the games dashboard from there (it displays the games list by default)
It also adds an item in the project manager that displays the game details of the opened project in a dialog.

Also:

  • when initial-dialog is used to open the details of a game, use the games dashboard displayed in the homepage
  • When right clicking on a project in the list and choosing "Manage game", the games dashboard from the homepage is opened

Screenshots

Project manager

When the opened project has already been published

image

When the user is not logged in nor the project has already been published

image

Homepage new tab

When the user is logged in

image image

When the user is not logged in

image

Tooltips

Desktop on the homepage menu

image

Mobile on the project manager

image

'game-id': gameId,
}),
click: () => onManageGame({ gameId }),
enabled: canManageGame({ gameId }),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the whole concat not happen if !canManageGame( {gameId}) ? It would avoid showing an item that's not clickable?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually prefer disabling items rather than having users think "there's a bug, this item should be here but it's not"

Copy link
Collaborator

@ClementPasteau ClementPasteau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!!!

@AlexandreSi AlexandreSi merged commit b6a1332 into master Nov 29, 2023
5 of 6 checks passed
@AlexandreSi AlexandreSi deleted the add-game-dashboard-on-home-page branch November 29, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants