Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible undefined iconFileName crashing the instruction list #5968

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

ClementPasteau
Copy link
Collaborator

Fix #5964 & #5958

@ClementPasteau ClementPasteau changed the title Fix possible undefined iconFileName Fix possible undefined iconFileName crashing the instruction list Nov 27, 2023
Copy link
Owner

@4ian 4ian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comment

Copy link
Collaborator

@AlexandreSi AlexandreSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClementPasteau ClementPasteau merged commit 6cd8f54 into master Nov 28, 2023
6 checks passed
@ClementPasteau ClementPasteau deleted the fix-possible-undefined-icon branch November 28, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash while using an editor
3 participants