Fix heavy assets failing to download on slow connections #6024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use a pool to limit concurrent downloads to 20. - Avoid 3D models used in different scenes to be downloaded several times
D8H
changed the title
4ian
approved these changes
Dec 6, 2023
GDJS/Runtime/Model3DManager.ts
Outdated
| @@ -114,6 +114,9 @@ namespace gdjs { | |||
| if (!loader) { | |||
| return; | |||
| } | |||
| if (this._loadedThreeModels.getFromName(resource.name)) { | |||
There was a problem hiding this comment.
Will this conflict with hot-reloading? The comment of the function says the contrary of what this line does.
There was a problem hiding this comment.
Actually, the comment is wrong, hot-reload doesn't handle resources refresh and we'd likely clear cache to handle it.
D8H
force-pushed
the
fix-fast-loading-timeout
branch
from
e7bd47d
to
9937986
Compare
4ian
reviewed
Dec 7, 2023
GDJS/Runtime/ResourceLoader.ts
Outdated
| const task = this._prioritizeScene(sceneName); | ||
| return new Promise<void>((resolve, reject) => { | ||
| if (!task) { | ||
| resolve(); | ||
| return; | ||
| } | ||
| task.registerCallback(() => { | ||
| this._isLoadingInBackground = true; |
4ian
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes