Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception when changing an external tilemap file after it was initially missing #6929

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

4ian
Copy link
Owner

@4ian 4ian commented Sep 6, 2024

  • Fix not removeChild being done so an extra pixi object was staying in the PIXI container of instances - leading to containsPoint being called on something that was supposed to have disappeared (and crashing because sprite transform in PIXI was gone).
  • Also add a proper error message and bug report in case of crash in PIXI rendering (but this would not be triggered by the problem fixed here - this is a different kind of exception being reported).
  • Asked on PixiJS github if we can catch exceptions in the "event handling"/interaction manager of PixiJS: try/catch for EventBoundary/EventSystem pixijs/pixijs#10910

Copy link
Collaborator

@D8H D8H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@4ian 4ian merged commit b9dbe6d into master Sep 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants