Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layout custom objects children according to their anchors in the editor #6939

Merged
merged 7 commits into from
Sep 17, 2024
Merged

Layout custom objects children according to their anchors in the editor #6939

merged 7 commits into from
Sep 17, 2024

Conversation

D8H
Copy link
Collaborator

@D8H D8H commented Sep 9, 2024 •
edited
Loading

Changes

  • Split the RendereredInstance for custom object in 2
    • a legacy one that uses child-objects and hidden properties for the layout
    • another one that use the initialInstances and child-objects Anchor behaviors in layouted mode (isInnerAreaFollowingParentSize)

@D8H D8H marked this pull request as ready for review September 16, 2024 09:35
@D8H D8H requested a review from 4ian as a code owner September 16, 2024 09:35
4ian
4ian approved these changes Sep 17, 2024
View reviewed changes
Copy link
Owner

@4ian 4ian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@D8H D8H merged commit ed3acd5 into master Sep 17, 2024
4 of 6 checks passed
@D8H D8H deleted the ebo-anchor-editor branch September 17, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4ian 4ian 4ian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@D8H @4ian