Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix object images not displaying on quick customization #6949

Merged
merged 1 commit into from
Sep 12, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion newIDE/app/src/QuickCustomization/ObjectPreview.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ type Props = {|
object: gdObject,
|};

const paddingSize = 10;
const styles = {
previewContainer: {
display: 'flex',
Expand Down Expand Up @@ -41,6 +42,12 @@ const styles = {
...textEllipsisStyle,
overflowWrap: 'break-word',
},
previewImage: {
position: 'relative',
objectFit: 'contain',
verticalAlign: 'middle',
pointerEvents: 'none',
},
};

export const ObjectPreview = ({ project, object }: Props) => {
Expand All @@ -65,7 +72,11 @@ export const ObjectPreview = ({ project, object }: Props) => {
project,
object.getConfiguration()
)}
style={{ maxWidth: 120, maxHeight: 120 }}
style={{
...styles.previewImage,
maxWidth: 128 - 2 * paddingSize,
maxHeight: 128 - 2 * paddingSize,
}}
/>
)}
</div>
Expand Down
Loading