Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of services Query-Parameter #93

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Implementation of services Query-Parameter #93

wants to merge 6 commits into from

Conversation

SpeckiJ
Copy link
Member

@SpeckiJ SpeckiJ commented Oct 26, 2017

This implements the Query Parameter on all Endpoints described in Issue #92.

As the service entity might not be mapped by hibernate but be injected by spring the filtering can not be done in Hibernate, and must be done after the results were retrieved from the database (only then is it certain that entities have the correct associated service entity.)

Added Service filter to `/stations` Endpoint [untested].
Added Service Parameter to all Repositories.
…ot to be implemented. (align docs with implementation)
…wanted but no custom createCondensed/createExpanded is implemented.
@SpeckiJ
Copy link
Member Author

SpeckiJ commented Nov 10, 2017

NOTE: Entity Counter currently has no way of supporting this Query Parameter (can not filter Spring injected variables due to previous Projection to single number inside Hibernate).

This breaks Pagination as it relies on EntityCounter counting correctly.

@ridoo ridoo added the v2.x label Jan 18, 2018
@ridoo
Copy link
Member

ridoo commented Feb 5, 2018

Some notes:

  • Why is addServiceFilter part of the repository (I'd expected it in AbstractDao or DbQuery to be more consistent with how other filteres are set currently)
  • Solutions looks to me to be a shotgun surgery.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants