Improve Objective-C interoperability with @objMembers attribute #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreabusi
force-pushed
the
feature/better-objc
branch
from
493f5b1
to
c803914
Compare
|
@BubiDevs Thanks for your PR! I will not be merging this commit into master, however I will leave this PR open for anyone who is looking to improve Objective-C interoperability with Pulley so they can find the required changes. The reason I will not be merging this is largely stated in this PR. As the desire for Pulley is primarily to be used as a Swift project the |
andreabusi
force-pushed
the
feature/better-objc
branch
from
c803914
to
734d5b3
Compare
andreabusi
force-pushed
the
feature/better-objc
branch
from
734d5b3
to
c122663
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to improve Objective-C interoperability, I added the @objMembers attribute to expose all the properties also to Objective-C project.
With these changes, we are able to use Pulley in our Objective-C only project.