Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

GS026: Invalid owner provided is displayed for the valid owners during batch tx simulation #4014

Open
liliya-soroka opened this issue Jul 6, 2022 · 4 comments
Assignees
Labels
Bug 🐛 Something isn't working Minor Needs to be fixed within the next 1-3 public releases.

Comments

@liliya-soroka
Copy link
Member

Description

GS026: Invalid owner provided is displayed for the valid owners during batch tx simulation

Environment

  • Browser: Chrome
  • Wallet: MetaMask
  • Chain: Gnosis Chain

Steps to reproduce

  1. Go to https://safe-team.dev.gnosisdev.com/app/gno:0x9DF58F04F3e914ED8D972146401C85313A53FecA/transactions/queue
  2. click batch execution for the txs with nonces 38 and 39

Expected result

I would expected that:

  1. GS026 will not be displayed for the owner
  2. any one can execute the tx , so GS026 is not expected for the execution at all

Obtained result

https://dashboard.tenderly.co/public/safe/safe-apps/simulator/78c92fb1-52b8-4dc0-8f45-b974724042c4
image

@liliya-soroka liliya-soroka added Bug 🐛 Something isn't working Major Needs to be fixed for immediate next public release. labels Jul 6, 2022
@liliya-soroka liliya-soroka moved this to Todo in Web Squad Jul 6, 2022
@schmanu
Copy link
Member

schmanu commented Jul 6, 2022

This seems to be an issue when updating a Safe from 1.1.1 to 1.3.0 and trying to batch this update with any other tx.

Steps to reproduce:

  1. 2/n safe with 1.1.1 contract
  2. Create and fully sign update safe tx
  3. Create a reject tx (or any other) and fully sign it
  4. Open Batch execute dialog and simulate the tx

Example safe with this setup:
https://safe-team.staging.gnosisdev.com/app/rin:0x6ff122E4a97D3c440450602fdc021A19f63bD2c1/balances

@schmanu
Copy link
Member

schmanu commented Jul 6, 2022

IMO the only front end solution I could think of is to exclude Safe update transactions from batch execution

@schmanu schmanu self-assigned this Jul 8, 2022
@johannesmoormann
Copy link

why is this a major bug? as long as users are not blocked and are able to carry out the update as a single transaction, I would consider this minor.

@johannesmoormann johannesmoormann added Minor Needs to be fixed within the next 1-3 public releases. and removed Major Needs to be fixed for immediate next public release. labels Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug 🐛 Something isn't working Minor Needs to be fixed within the next 1-3 public releases.
Projects
None yet
Development

No branches or pull requests

4 participants
@liliya-soroka @schmanu @johannesmoormann and others