feat: Add batch execute button and tx highlighting #352
Conversation
ESLint Summary View Full Report
Report generated by eslint-plus-action |
Deploying with
|
| Latest commit: |
d318c75
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bb7cea5d.web-core.pages.dev |
| Branch Preview URL: | https://batch-execute.web-core.pages.dev |
| import { styled } from '@mui/material/styles' | ||
| import Tooltip, { tooltipClasses, TooltipProps } from '@mui/material/Tooltip' | ||
|
|
||
| const CustomTooltip = styled(({ className, ...props }: TooltipProps) => ( |
There was a problem hiding this comment.
Only extracted this so it can be reused
usame-algan
changed the title
src/components/transactions/BatchExecuteButton/__tests__/BatchExecute.test.tsx
Outdated
Show resolved
Hide resolved
src/components/transactions/TxListItem/ExpandableTransactionItem.tsx
Outdated
Show resolved
Hide resolved
| batchableTransactions.length < BATCH_LIMIT && | ||
| isMultisigExecutionInfo(tx.transaction.executionInfo) && | ||
| tx.transaction.executionInfo.nonce === currentNonce && | ||
| tx.transaction.executionInfo.confirmationsSubmitted >= tx.transaction.executionInfo.confirmationsRequired |
There was a problem hiding this comment.
I know its just a minor bug but lets add a condition here that we stop adding txs to the batch if an update safe tx was added.
5afe/safe-react#4014
There was a problem hiding this comment.
As discussed lets tackle this in a separate task as it involves decoding each tx which could blow up the scope
| import { selectPendingTxs } from '@/store/pendingTxsSlice' | ||
| import CustomTooltip from '@/components/common/CustomTooltip' | ||
|
|
||
| const BATCH_LIMIT = 10 |
There was a problem hiding this comment.
I know it was 10 txs before. But I'm not 100% sure where the 10 is coming from. Is it about the block gas limit?
If yes: Some apps like tx builder / csv airdrop can by itself create huge txs. 10 of those would not fit.
There was a problem hiding this comment.
As far as I remember we chose 10 arbitrarily. By default we get 20 per page now I think so we could increase it to that
There was a problem hiding this comment.
Actually now infinite scroll makes more sense. 🤔
What it solves
ToDos
Screenshots