This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
feat: Dashboard grid layout #3795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
Looks wonderful! |
iamacook
reviewed
Apr 19, 2022
src/components/Dashboard/styled.tsx
Outdated
| margin-top: 0; | ||
| ` | ||
|
|
||
| export const WidgetBody = styled.div<{ filled?: boolean }>` |
There was a problem hiding this comment.
Removed 👍 it was a leftover from a previous style
…random apps, adjust grid layout
…into dashboard-grid-layout
iamacook
approved these changes
Apr 20, 2022
src/routes/routes.ts
Outdated
| @@ -50,7 +50,7 @@ export const LOAD_SAFE_ROUTE = generatePath(LOAD_SPECIFIC_SAFE_ROUTE) // By prov | |||
| export const SAFE_ROUTES = { | |||
| DASHBOARD: `${ADDRESSED_ROUTE}/home`, | |||
| ASSETS_BALANCES: `${ADDRESSED_ROUTE}/balances`, // [SAFE_SECTION_SLUG] === 'balances' | |||
| ASSETS_BALANCES_COLLECTIBLES: `${ADDRESSED_ROUTE}/balances/collectibles`, // [SAFE_SUBSECTION_SLUG] === 'collectibles' | |||
| ASSETS_BALANCES_COLLECTIBLES: `${ADDRESSED_ROUTE}/balances/nfts`, // [SAFE_SUBSECTION_SLUG] === 'collectibles' | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
Part of #3693
How this PR fixes it
Displays dashboard widget in a grid
How to test it
/homeScreenshots