Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply fixes from StyleCI #166

Merged
merged 1 commit into from
Aug 6, 2023

Conversation

mechelon
Copy link
Member

@mechelon mechelon commented Aug 6, 2023

This pull request applies code style fixes from an analysis carried out by StyleCI.


For more information, click here.

@mechelon mechelon merged commit ceb61fe into refactor/snapshot-replay-testing Aug 6, 2023
0 of 2 checks passed
@mechelon mechelon deleted the analysis-wOJJeW branch August 6, 2023 06:27
@what-the-diff
Copy link

what-the-diff bot commented Aug 6, 2023

PR Summary

  • New retrieve method in Page class
    This PR introduces a new function called 'retrieve' in the 'Page.php' class. This function will make it possible to get details of a specific property on a page.

  • Added validations in PestHttpRecorder
    The 'PestHttpRecorder.php' class received additional validations. These validations ensure that URLs are properly formatted as an array before they are processed, helping prevent potential software crashes due to malformed input.

  • Formatting condition for 'queryName' in PestHttpRecorder
    There is an added condition to make sure 'queryName', which helps query the database, is always correctly styled for intended use. This enhancement will ensure smoother operations when performing certain tasks.

  • Version validation in Notion class
    The 'Notion.php' class now has an added feature to validate versions. This ensures all provided versions are correct and valid, reducing the risk of unexpected failures due to incorrect versions.

  • Cleanup and Optimizations in RecordedEndpointPageTest
    In 'RecordedEndpointPageTest.php', unnecessary imports were removed to make the code cleaner and easier to understand. In addition to that, specific property keys that aren't necessary for the tests to run are now skipped, ensuring tests run smoothly and efficiently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants