test: 댓글 작성 시, 멘션 ID에 Null일 경우 테스트 코드 작성 #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pparkjs
approved these changes
Jan 18, 2025
| import java.util.List; | ||
|
|
||
| public record CommentCreateRequest( | ||
| String content, | ||
| List<Long> mentionIds | ||
| @NotNull(message = "댓글 작성 시 멘션 ID에 Null이 될 수 없습니다.") List<Long> mentionIds |
There was a problem hiding this comment.
기존 VO 방식이 아닌 @Valid 어노테이션으로 유효성 검사 한 이유가 있을까요!?
There was a problem hiding this comment.
아래 사진은 댓글을 생성하는 메서드인 CommentService#create() 입니다.
현재 파라미터로 List<Long> mentionIds 를 받고 있습니다.
이 값에 null이 들어올 경우 mentionService.toMentions(mentionIds); 라인에서 예외가 발생해서 추가했습니다.
Mention의 경우 Mentions 라는 VO 가 존재하지 않으며, �해당 로직만을 위해 추가하는 것은 공수가 불필요하게 많이 들어간다고 판단했습니다.
또, null 체크 정도는 Domain 계층이 아닌 Controller 계층에서 해도 적절하다고 생각합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
댓글 작성 시, 멘션 ID에 Null일 경우 테스트 코드 작성했습니다.
동시에
@Valid를 이용한 검증과, 검증 실패 시 발생하는 예외 핸들링을 약간 수정했습니다.Relation Issues