Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bad import in calculator tool example #20

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dajulia3
Copy link

In the repo structure, the package is just called "agent_framework" ... this example is out of date. Maybe internally you guys have a repository that you pull from where you have the xrx_agent_framework package published, but in the OSS project the submodule structure just has an "agent_framework" directory in the xrx-core submodule.

It's not a big deal but it did make me question if there was some pypi package that I should reference instead of the submodule. So it's probably still worth correcting :).

In the repo structure, the package is just called "agent_framework" ... this example is out of date

Signed-off-by: David Julia <[email protected]>
@alessandro-neri
Copy link
Contributor

Hello @dajulia3 and thank you for contributing.
Could you better explain the issue?

The name of the folder is "xrx_agent_framework" both in main and develop.
For this reason the import should be: from xrx_agent_framework import observability_decorator
I attached a screenshot below.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants