-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
variable subscription function #15
base: master
Are you sure you want to change the base?
Conversation
Call this function from the variable subscription to enable radio buttons
Hi, We would need the complete functional code to merge it. thanks |
Woothemes hasnt replied. Based on it being a GPLv3 license, I should be fine to post. I have updated the code to include the whole variable-subscription.php file. Yes it should be in templates/single-product/add-to-cart/variable-subscription.php |
I was thinking we should put that template in a different folder like |
Renaming the variable.php file to variable-subscriptions.php and replacing the file in the add-to-cart folder (in either the plugin or child theme) doesn't seem to work for Variable Subscriptions as suggested here: http://ideas.woocommerce.com/forums/133476-woocommerce/suggestions/2459699-radio-buttons-for-attributes-variations I'm using the default WooCommerce Storefront theme... Does this still work? |
This should work fine. I wouldn't know how to structure that. Would that just be a php include? |
Have you tried the code located here: The complete variable-subscription.php file is located at the link. Make sure you use the code in green. You will need to update your variable-subscription.php file. I would HIGHLY recommend you do this in your child theme. Variable-subscriptions calls more parameters than just variables. Therefore renaming the file will not work. |
@GoodGuyTaj |
That would be great! |
Hi there. I am having this issue with variable subscriptions and this plugin also. I tried adding the new variable-subscription.php to my child theme but the variable subscriptions is still broken. Just wondering if you can provide any assistance? Is there perhaps a way to disable the radio buttons just for variable subscriptions so that they are still functional? Thanks! |
Hi. I assume you are not using the standard wordpress theme? Can you try the standard variable subscription on the standard wordpress theme and let us know if that works? For my theme, I had to do some modifications to get the wc-variation-radio-buttons to work, but it was relatively minor php/html coding. |
Hi. Thanks for your reply. I tried it with the default 2016 theme and the variable subscriptions still isn't working. I also tried placing the updated variable-subscription.php directly into the subscriptions plugin to make sure it was using the new file, but no luck. |
That is very strange. The variable subscriptions should work on the default theme out of the box. What kind of errors are you getting? Does wc-variations-radio-buttons not work either on the default them? THe updated variable-subscription.php will likely not work without wc-variations-radio-buttons working. |
The variations still appear as a dropdown box and when one is selected the price doesn't appear. I have attached a screenshot with the radio button plugin enabled and disabled. |
@dylkelson Ok. The price issue is an easy fix. Can you go ahead and start a thread in the issue tab? |
I am having trouble getting this fix to work either. The problem I'm having is that a wrong price is shown and doesn't change when picking a variation. I am also using the Wooocommerce Subscriptions plugin, latest version. |
Hi - before I go messing around with code - Does anyone have this working please? Or have another solution? thanks... |
Hi everyone, I have updated the code to work with latest WC and WC Subscription plugin. Enjoy. Basically what you need to keep during updating below code are:
The rest can be updated. template here: https://gist.github.com/FawadNL/3ac090aeff2a0dcb06da6d4992f99309 |
@Mantish Can we get this PR accepted and pushed to WordPress Plugin Repo? |
Call this function from the variable subscription to enable radio buttons. I will talk with WooThemes and see if they will let me post the whole variable-subcription.php file.