feat: Add profile option to always view full names in event view

app/controllers/members_controller.rb

@@ -239,7 +239,7 @@ def member_params
       params.require(:member).permit(
         :password, :password_confirmation, :email, :namefirst, :namelast, :namenick, :title, :callsign,
         :shirt_size, :phone, :payrate, :role, :tracker_dev, :receives_comment_emails,
-        :on_payroll, :pronouns, :favorite_entropy_drink, :major, :grad_year, :interests, :officer_position,
+        :on_payroll, :pronouns, :favorite_entropy_drink, :prefers_full_name, :major, :grad_year, :interests, :officer_position,
         :super_tics_attributes => [:id, :_destroy, :day]
       )
     end

app/helpers/events_helper.rb

@@ -149,8 +149,10 @@ def show_run_position(er, hover)
     elsif er.appliable and not er.assigned? and can? :create, er.applications.build(member: current_member)
       return link_to("you?", new_application_url(er.event, event_role_id: er.id, format: :js), :remote => true) unless hover
       "you?" if hover
+    elsif !hover and current_member and current_member.prefers_full_name
+      return er.assigned_to :both_names
     elsif !hover and current_member
-      er.assigned_to use_display_name: true
+      return er.assigned_to :display_name
     else
       er.assigned_to
     end
@@ -166,4 +168,13 @@ def weeks_from_now(weeks)
     end
   end
 
+  def run_position_name_preference(member)
+    if !member
+      return :full_name
+    elsif member.prefers_full_name
+      return :both_names
+    else
+      return :display_name
+    end
+  end
 end

app/models/event_role.rb

@@ -112,12 +112,16 @@ def to_s
     role + ": " + assigned_to
   end
 
-  def assigned_to(options = {})
+  def assigned_to(mode = :full_name)
+    # Logger
     if assigned?
-      if options[:use_display_name]
-        member.display_name
-      else
+      case mode
+      when :full_name
         member.fullname
+      when :display_name
+        member.display_name
+      when :both_names
+        "#{member.display_name} (#{member.fullname})"
       end
     else
       "(unassigned)"

app/views/events/_event_role_fields.html.erb

@@ -11,11 +11,11 @@
     <td><%= link_to_remove_fields image_tag("cross.png"), f, f.object.new_record? %></td>
   <% elsif f.object.member == current_member %>
     <td><%= f.object.role %></td>
-    <td><%= f.object.assigned_to use_display_name: true %></td>
+    <td><%= f.object.assigned_to(run_position_name_preference(current_member)) %></td>
     <td></td>
     <td><%= link_to_remove_fields image_tag("cross.png"), f %></td>
   <% else %>
     <td><%= f.object.role %></td>
-    <td><%= f.object.assigned_to use_display_name: true %></td>
+    <td><%= f.object.assigned_to(run_position_name_preference(current_member)) %></td>
   <% end %>
-</tr>
+</tr>

app/views/members/_form.html.erb

@@ -98,11 +98,16 @@
       <dd><%= f.text_field :interests, class: "wide-input" %></dd>
     </dl>
 
+    <dl>
+        <dt><%= f.label :prefers_full_name, "Show full names of members:" %></dt>
+        <dd><%= f.check_box :prefers_full_name %></dd>
+    </dl>
+
   </fieldset>
 
   <fieldset>
     <legend>Notifications</legend>
-  
+
     <dl>
       <dt><%= f.check_box :receives_comment_emails %></dt>
       <dd><%= f.label :receives_comment_emails, "Email me when comments are posted on events I have run positions for" %></dd>

app/views/members/show.html.erb

@@ -111,6 +111,12 @@
         <th>Interests</td>
         <td><%= @member.interests %></td>
       </tr>
+      <% if @member == current_member %>
+        <tr>
+          <th>Show real names of members</td>
+          <td><%= @member.prefers_full_name ? "YES" : "NO" %></td>
+        </tr>
+      <% end %>
       </table>
     </td>
     <% if can? :read, Timecard %>

db/migrate/20241007223900_add_profile_option_view_full_name.rb

@@ -0,0 +1,6 @@
+class AddProfileOptionViewFullName < ActiveRecord::Migration[6.1]
+  def change
+    # Change members table; Add column prefers_full_name
+    add_column :members, :prefers_full_name, :boolean, default: false
+  end
+end