Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bitcoin-kmp 0.13.0 #2708

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Use bitcoin-kmp 0.13.0 #2708

merged 1 commit into from
Aug 21, 2023

Conversation

sstone
Copy link
Member

@sstone sstone commented Jul 6, 2023

@codecov-commenter
Copy link

codecov-commenter commented Jul 6, 2023

Codecov Report

Merging #2708 (a8ddc1e) into master (ef25e32) will decrease coverage by 0.03%.
The diff coverage is 57.14%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #2708      +/-   ##
==========================================
- Coverage   85.91%   85.88%   -0.03%     
==========================================
  Files         215      215              
  Lines       17818    17823       +5     
  Branches      791      761      -30     
==========================================
- Hits        15308    15307       -1     
- Misses       2510     2516       +6     
Files Changed Coverage Δ
...-core/src/main/scala/fr/acinq/eclair/package.scala 73.52% <ø> (-0.76%) ⬇️
...r-core/src/main/scala/fr/acinq/eclair/Eclair.scala 57.65% <57.14%> (-0.22%) ⬇️

... and 3 files with indirect coverage changes

@sstone sstone marked this pull request as ready for review August 20, 2023 18:17
@sstone sstone requested a review from t-bast August 20, 2023 18:17
Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once we're using the 0.29 tag instead of 0.29-SNAPSHOT 👍

@sstone
Copy link
Member Author

sstone commented Aug 21, 2023

LGTM once we're using the 0.29 tag instead of 0.29-SNAPSHOT 👍

Done in 4b3fb1a (bitcoin-lib 0.29 has just been published to maven central)

@sstone sstone merged commit 3547f87 into master Aug 21, 2023
1 check passed
@sstone sstone deleted the use-bitcoin-kmp-0.13-0 branch August 21, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants