Offer test vectors #2723
Offer test vectors #2723
Conversation
thomash-acinq
commented
Aug 14, 2023
•
thomash-acinq
commented
- Add test vectors from Offers lightning/bolts#798
- Update the TLV ranges for offers and invoice requests
thomash-acinq
force-pushed
the
offer-test
branch
from
d2fc24e
to
9afe550
Compare
|
Should we update this with the latest test vectors from the Bolt 12 spec PR @thomash-acinq? Are the spec test vectors up-to-date or are we waiting for changes there? |
Add test vectors from lightning/bolts#798 Update the TLV ranges for offers and invoice requests
thomash-acinq
force-pushed
the
offer-test
branch
from
9afe550
to
af35aa0
Compare
|
I've updated the test vectors and the TLV ranges for offers.
I've modified the test vectors for these two cases but it should be updated in the spec. |
There was a problem hiding this comment.
The reason why this was this was still a draft is that there are two cases where I disagree with the spec test vectors:
Gotcha, I'm not sure about the feature bit one, but the other one I agree with you. Can you make sure this is discussed on the spec PR and Rusty is aware of it, so that we can converge? We'll need everyone to validate the test vectors to be able to merge the spec PR.
