Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination for channelstats RPC #2890

Merged
merged 3 commits into from
Aug 1, 2024
Merged

Pagination for channelstats RPC #2890

merged 3 commits into from
Aug 1, 2024

Conversation

rorp
Copy link
Contributor

@rorp rorp commented Jul 28, 2024

No description provided.

t-bast
t-bast reviewed Jul 29, 2024
View reviewed changes
Copy link
Member

@t-bast t-bast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Can you update the release notes to mention that this API now provides pagination, to ensure that we correctly document it with the next release?

@rorp rorp requested a review from t-bast August 1, 2024 00:55
@t-bast t-bast merged commit c45d278 into ACINQ:master Aug 1, 2024
1 check passed
@viaj3ro viaj3ro mentioned this pull request Aug 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-bast t-bast t-bast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rorp @t-bast