-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get ready for storing partial commit signatures #2896
base: input-info-taproot
Are you sure you want to change the base?
Conversation
aa0a099
to
cf583ea
Compare
46ef2b7
to
155b8dc
Compare
cf583ea
to
8e147fb
Compare
452c0e0
to
16e75b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit, but otherwise seems like straight forward changes.
val commitTxAndRemoteSigCodec: Codec[CommitTxAndRemoteSig] = ( | ||
private case class CommitTxAndRemoteSigEx(commitTx: CommitTx, remoteSig: ByteVector64, partialSig: Either[ByteVector64, PartialSignatureWithNonce], dummy: Boolean) | ||
|
||
// remoteSig is now either a signature or a partial signature with nonce. To retain compatibility with the previous codec, we use remoteSig as a left/write indicator, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: s/write/right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 57310de
145fba5
to
4163f0e
Compare
57310de
to
0ac5a45
Compare
We currently store our peer's signature for our remote commit tx, so we can publish it if needed. If we upgrade funding tx to use musig2 instead of multisig 2-of-2 we will need to store a partial signature instead.
4163f0e
to
e15cb29
Compare
0ac5a45
to
af1d5c7
Compare
This is another preparation PR for simple taproot channels that builds on top of #2895.
We currently store our peer's signature for our remote commit tx, so we can publish it if needed. If we upgrade funding tx to use musig2 instead of multisig 2-of-2 we will need to store a partial signature instead.