splice: Improve abort feerate abort msg #2911
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
reviewed
Sep 23, 2024
There was a problem hiding this comment.
I'm not sure this is where the error you're seeing is created, this is only for the case where you try to use a feerate that is below our mempool minimum feerate. I think you're getting an error inside the InteractiveTxBuilder, I'll look into improving the error message.
| @@ -979,8 +979,8 @@ class Channel(val nodeParams: NodeParams, val wallet: OnChainChannelFunder with | |||
| log.info("rejecting splice request: channel not quiescent") | |||
| stay() using d.copy(spliceStatus = SpliceStatus.SpliceAborted) sending TxAbort(d.channelId, InvalidSpliceNotQuiescent(d.channelId).getMessage) | |||
| } else if (msg.feerate < nodeParams.currentFeerates.minimum) { | |||
| log.info("rejecting splice request: feerate too low") | |||
| stay() using d.copy(spliceStatus = SpliceStatus.SpliceAborted) sending TxAbort(d.channelId, InvalidSpliceRequest(d.channelId).getMessage) | |||
| log.info(s"rejecting splice request: feerate ${msg.fundingContribution} too low, must be above ${nodeParams.currentFeerates.minimum}") | |||
There was a problem hiding this comment.
Suggested change
| log.info(s"rejecting splice request: feerate ${msg.fundingContribution} too low, must be above ${nodeParams.currentFeerates.minimum}") | |
| log.info(s"rejecting splice request: feerate ${msg.feerate} too low, must be above ${nodeParams.currentFeerates.minimum}") |
Added an explanation for aborting the splice if the feerate is too low
ddustin
force-pushed
the
ddustin/splicing_feerate
branch
from
3652211
to
1b28236
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an explanation for aborting the splice if the feerate is too low