Take min feerate into account for recommended fees #2918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Independently of target and tolerance ratios, transactions must be publishable in our local mempool. We must be careful that fee ranges stay above this min fee level. In theory we shouldn't need to care about the upper range, but I'm not sure that, depending on the fee estimator, the min fee is always lower than arbitrary block targets.
t-bast
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Independently of target and tolerance ratios, transactions must be publishable in our local mempool. We must be careful that fee ranges stay above this min fee level.
In theory we shouldn't need to care about the upper range, but I'm not sure that, depending on the fee estimator, the min fee is always lower than arbitrary block targets.