-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented dark mode on app #16
Conversation
Thanks @All3yp, for opening the pull request! 🙌 |
@Samridh29 sorry. I didn't understand at first, but now it's done, with persistent state implemented using UserDefaults. I implemented a UISwitch to change dark and light mode. I also used simple custom Color Assets. I hope you like it when you review it! 😁 |
Hey, @All3yp great work! I found a few bugs while simulating the app. The dark mode implemented is not across all the screens so if you can fix it asap we will be good to go. |
Hi @Samridh29 , I ended up not testing the colors on the details screen and hadn't seen it, I apologize. |
@All3yp great job on implementing dark mode. Looks pretty sick!! |
Congratulations @All3yp, your pull request is merged! 🎉 |
Hello. 😁
This is my solution to fix issue #12