Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented dark mode on app #16

Merged
merged 3 commits into from
Oct 6, 2021
Merged

Implemented dark mode on app #16

merged 3 commits into from
Oct 6, 2021

Conversation

All3yp
Copy link
Contributor

@All3yp All3yp commented Oct 5, 2021

Hello. 😁
This is my solution to fix issue #12

@acmbot
Copy link

acmbot bot commented Oct 5, 2021

Thanks @All3yp, for opening the pull request! 🙌
One of our team-mates will review the pull request soon. ✅

@Samridh29
Copy link
Collaborator

Samridh29 commented Oct 6, 2021

@All3yp Toggling between light and dark mode from within the app isn't working. Add toggle button to switch between modes and save them.
Refer to #3 to get an idea of what to do.

@All3yp
Copy link
Contributor Author

All3yp commented Oct 6, 2021

@Samridh29 sorry. I didn't understand at first, but now it's done, with persistent state implemented using UserDefaults. I implemented a UISwitch to change dark and light mode. I also used simple custom Color Assets. I hope you like it when you review it! 😁

@Samridh29
Copy link
Collaborator

Samridh29 commented Oct 6, 2021

Hey, @All3yp great work! I found a few bugs while simulating the app. The dark mode implemented is not across all the screens so if you can fix it asap we will be good to go.
Simulator Screen Shot - iPhone 12 Pro Max - 2021-10-06 at 21 40 19

Simulator Screen Shot - iPhone 12 Pro Max - 2021-10-06 at 21 40 25

@All3yp
Copy link
Contributor Author

All3yp commented Oct 6, 2021

Hi @Samridh29 , I ended up not testing the colors on the details screen and hadn't seen it, I apologize.
Problem solved now. 😁

@Samridh29 Samridh29 self-requested a review October 6, 2021 17:54
@Samridh29
Copy link
Collaborator

@All3yp great job on implementing dark mode. Looks pretty sick!!

@Samridh29 Samridh29 merged commit b54921e into ACM-VIT:main Oct 6, 2021
@acmbot
Copy link

acmbot bot commented Oct 6, 2021

Congratulations @All3yp, your pull request is merged! 🎉
Thanks for your contributions. 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants