Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: EventManager #4

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Feature: EventManager #4

wants to merge 9 commits into from

Conversation

LuckierDodge
Copy link
Member

@LuckierDodge LuckierDodge commented Dec 4, 2024 •
edited
Loading

PR Info

Working to add basic Event logging functionality to MADSci

  • Better dev container initialization experience (auto installs pdm project and common dependencies, sets default python interpreter appropriately)
  • Combines functionality from WEI events and logger into a single EventClient and EventManager
  • Move the ConfigParameter type to config_types.py so that it can be generalized to any MADSci component configuration

Developer Checklists

I have:

  • Run Pre-commit and Unit Tests, and ensured that they pass
  • Created or updated documentation relevant to your change
  • Created or updated unit tests relevant to your change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LuckierDodge