Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Compatibility with AFNetworking 3 and HTTP/2 #22

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

abbasmousavi
Copy link

@abbasmousavi abbasmousavi commented Jun 1, 2016

Using AFHTTPSessionManager instead of AFHTTPRequestOperation so that we can use AFJSONRPCClient with AFNetworking 3 and send JSON-RPC request over HTTP/2

@abbasmousavi abbasmousavi changed the title Using AFHTTPSessionManager instead of AFHTTPRequestOperation Compatibility with AFNetworking 3 and HTTP/2. Using AFHTTPSessionManager instead of AFHTTPRequestOperation Jun 1, 2016
@abbasmousavi abbasmousavi changed the title Compatibility with AFNetworking 3 and HTTP/2. Using AFHTTPSessionManager instead of AFHTTPRequestOperation Compatibility with AFNetworking 3 and HTTP/2 Jun 1, 2016
@abbasmousavi
Copy link
Author

@mattt @kylef @cnoon @kcharwood @wiistriker
Would you please review this PR.

@@ -21,14 +21,14 @@
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
// THE SOFTWARE.

#import "AFHTTPRequestOperationManager.h"
#import "AFHTTPSessionManager.h"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably just import AFNetworkings framework header.

#import <AFNetworking/AFNetworking.h>

@abbasmousavi
Copy link
Author

@kylef Yes, I have fixed it. Thanks.


s.dependency 'AFNetworking', '~> 2.1'
s.dependency 'AFNetworking', '> 2.1'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to lock to ~> 3.0 or perhaps a range of > 2.1, < 4.0 if AFNetworking 2 should still be supported. Otherwise any breaking changes in AFNetworking 4.0 would break AFJSONRPCClient.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code only works with AFNetworking 3.0, It is better to lock it to ~> 3.0.
We can create a branch with current code for AFNetworking 2.0 if anyone uses it.
I have changed it in a new commit.
@kylef

@abbasmousavi
Copy link
Author

abbasmousavi commented Feb 22, 2018

@kylef @handya
Could you please merge this pull request and release a new pod version?

@abbasmousavi
Copy link
Author

@kylef @handya

@dents
Copy link

dents commented Apr 27, 2018

Any chance of getting this checked in?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants