Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create repos for tutorials #21

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Create repos for tutorials #21

merged 1 commit into from
Sep 2, 2021

Conversation

pacospace
Copy link

@pacospace pacospace commented Sep 1, 2021 •
edited
Loading

Signed-off-by: Francesco Murdaca [email protected]

4 repos for 4 new tutorials:

Example 1 - manage-dependencies-tutorial
Example 2 - recommend-base-image-tutorial
Example 3 - overlays-for-ai-pipeline-tutorial
Example 4 - receive-feedback-on-deployment-tutorial

Related-To: thoth-station/core#308

Create repos for tutorials
1160cb7 
Signed-off-by: Francesco Murdaca <[email protected]>
@sesheta
Copy link

sesheta commented Sep 1, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign goern after the PR has been reviewed.
You can assign the PR to them by writing /assign @goern in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta sesheta requested review from harshad16 and tumido September 1, 2021 15:19
@sesheta sesheta added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 1, 2021
@goern
Copy link
Member

goern commented Sep 2, 2021

/approve

tumido
tumido approved these changes Sep 2, 2021
View reviewed changes
Copy link
Member

@tumido tumido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@tumido
Copy link
Member

tumido commented Sep 2, 2021

CI not working, I'll apply the config manually. Merging

@tumido tumido merged commit b22edc4 into AICoE:main Sep 2, 2021
@pacospace
Copy link
Author

pacospace commented Sep 2, 2021 •
edited
Loading

CI not working, I'll apply the config manually. Merging

How much time does it take usually to create repos? cc @tumido

@goern
Copy link
Member

goern commented Sep 3, 2021

peribolos just finished running from my local host.

@pacospace pls chk

@pacospace
Copy link
Author

peribolos just finished running from my local host.

@pacospace pls chk

All available!! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tumido tumido tumido approved these changes

@harshad16 harshad16 Awaiting requested review from harshad16

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pacospace @sesheta @goern @tumido