Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Add tutorial steps for manage dependencies #3

Merged
merged 29 commits into from
Sep 15, 2021
Merged

Add tutorial steps for manage dependencies #3

merged 29 commits into from
Sep 15, 2021

Conversation

pacospace
Copy link

@pacospace pacospace commented Sep 7, 2021 •
edited
Loading

Fixes: #1

Depends-On: operate-first/apps#972

Francesco Murdaca added 5 commits September 7, 2021 12:42
Add pre-requisite
6d473e9 
Signed-off-by: Francesco Murdaca <[email protected]>
Add push changes
5ec6b49 
Signed-off-by: Francesco Murdaca <[email protected]>
Add Thoth and AICOE steps
4e0fa18 
Signed-off-by: Francesco Murdaca <[email protected]>
Setup initial environment docs
cef4436 
Signed-off-by: Francesco Murdaca <[email protected]>
Update README for tutorial
0153ab5 
Signed-off-by: Francesco Murdaca <[email protected]>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@pacospace pacospace requested review from goern and harshad16 and removed request for durandom and tumido September 7, 2021 13:23
@pacospace pacospace requested a review from codificat September 7, 2021 14:14
codificat
codificat reviewed Sep 8, 2021
View reviewed changes
Copy link
Member

@codificat codificat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments on the initial README.
As a newcomer to the topic, I think it could be improved by restructuring it a bit, making a more clear distinction between the specific goals of the tutorial (what are dependencies, why do I want to manage them in a specific way) and the context around it (thoth, pipelines and bots, operate first)

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
@pacospace pacospace requested a review from codificat September 8, 2021 13:24
@pacospace
Copy link
Author

Some comments on the initial README.
As a newcomer to the topic, I think it could be improved by restructuring it a bit, making a more clear distinction between the specific goals of the tutorial (what are dependencies, why do I want to manage them in a specific way) and the context around it (thoth, pipelines and bots, operate first)

Thanks @codificat for all the suggestions!! I modified the README adding more description, let me know!

@pacospace pacospace force-pushed the add-tutorial-steps branch 3 times, most recently from d31767a to 2614387 Compare September 8, 2021 13:46
Adjust context
8b1c5ca 
Signed-off-by: Francesco Murdaca <[email protected]>
Francesco Murdaca added 2 commits September 8, 2021 15:54
Add what you will learn section
760c9ef 
Signed-off-by: Francesco Murdaca <[email protected]>
update pre-commit
64115b6 
Signed-off-by: Francesco Murdaca <[email protected]>
Add missing configs
e3a20ec 
Signed-off-by: Francesco Murdaca <[email protected]>
@sesheta sesheta added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 13, 2021
oindrillac
oindrillac suggested changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@oindrillac oindrillac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very useful tutorial @pacospace! 💯
Added a few comments and requested some minor grammar changes

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/share-your-work.md Outdated Show resolved Hide resolved
docs/start-notebook-and-manage-dependencies.md Outdated Show resolved Hide resolved
docs/start-notebook-and-manage-dependencies.md Show resolved Hide resolved
docs/start-notebook-and-manage-dependencies.md Outdated Show resolved Hide resolved
docs/start-notebook-and-manage-dependencies.md Outdated Show resolved Hide resolved
Francesco Murdaca and others added 10 commits September 14, 2021 09:05
@oindrillac
Improve and correct README.md
598a4ec 
Co-authored-by: Oindrilla Chatterjee <[email protected]>
@oindrillac
Improve and correct README.md
880a291 
Co-authored-by: Oindrilla Chatterjee <[email protected]>
@oindrillac
Improve and correct README.md
838e1c2 
Co-authored-by: Oindrilla Chatterjee <[email protected]>
@oindrillac
Improve and correct README.md
9e8e852 
Co-authored-by: Oindrilla Chatterjee <[email protected]>
@oindrillac
Improve and correct README.md
19edbbf 
Co-authored-by: Oindrilla Chatterjee <[email protected]>
Adjust from reviews
bb7ce09 
Signed-off-by: Francesco Murdaca <[email protected]>
@oindrillac
Update docs/share-your-work.md
ac5db4d 
Co-authored-by: Oindrilla Chatterjee <[email protected]>
@oindrillac
Update docs/share-your-work.md
86670e2 
Co-authored-by: Oindrilla Chatterjee <[email protected]>
@oindrillac
Update docs/share-your-work.md
8e5118c 
Co-authored-by: Oindrilla Chatterjee <[email protected]>
@oindrillac
Update docs/start-notebook-and-manage-dependencies.md
3fdef81 
Co-authored-by: Oindrilla Chatterjee <[email protected]>
@pacospace
Copy link
Author

Very useful tutorial @pacospace!
Added a few comments and requested some minor grammar changes

Thanks a lot for the reviews @oindrillac!! More tutorials coming focusing on specific things (subset of the Elyra tutorial)! thoth-station/core#308

@pacospace
Copy link
Author

/retest

@MichaelClifford
Copy link
Member

Great Tutorial @pacospace !

@pacospace
Copy link
Author

/approve

@sesheta sesheta added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2021
@goern
Copy link
Member

goern commented Sep 14, 2021

/approve
💯

@pacospace please also prepare a tweet ;) this needs to be send out to the universe

oindrillac
oindrillac approved these changes Sep 14, 2021
View reviewed changes
Copy link
Contributor

@oindrillac oindrillac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm 👏

@sesheta
Copy link
Contributor

sesheta commented Sep 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: goern, MichaelClifford, oindrillac, pacospace

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16
Copy link
Member

/test all

@harshad16 harshad16 merged commit 0ab0c56 into AICoE:master Sep 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@oindrillac oindrillac oindrillac approved these changes

@MichaelClifford MichaelClifford MichaelClifford approved these changes

@goern goern Awaiting requested review from goern

@harshad16 harshad16 Awaiting requested review from harshad16

@codificat codificat Awaiting requested review from codificat

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create manage dependencies tutorial
7 participants
@pacospace @MichaelClifford @goern @sesheta @harshad16 @codificat @oindrillac