Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance handling of transformations in VolumeBuilder #1263

Conversation

tomlatham
Copy link
Contributor

The VolumeBuilder helper class has a store for transformations and a function to populate it from the XML but that function is never called. In addition there is no access function (analogous to getShape or volume) to retrieve the transformations from the store. This PR adds a call to buildTransformations in the load function to populate the store and adds a new getTransform function to retrieve objects from the store.

BEGINRELEASENOTES

  • Enhance handling of transformations in VolumeBuilder

ENDRELEASENOTES

Copy link

Test Results

   14 files     14 suites   7h 19m 22s ⏱️
  363 tests   362 ✅ 0 💤 1 ❌
2 496 runs  2 495 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 61d1653.

@MarkusFrankATcernch MarkusFrankATcernch merged commit d5a4b3c into AIDASoft:master May 16, 2024
13 of 14 checks passed
@tomlatham tomlatham deleted the tomlatham_volumebuilder_transformations branch May 16, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants