Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding CylindricalGridPhiZ files #1294

Merged
merged 8 commits into from
Jul 24, 2024
Merged

Adding CylindricalGridPhiZ files #1294

merged 8 commits into from
Jul 24, 2024

Conversation

ybedfer
Copy link
Contributor

@ybedfer ybedfer commented Jul 11, 2024 •
edited by andresailer
Loading

Segmentation , plugin and dictionary are modified to include "CylindricalGridPhiZ".

  • "CylindricalGridPhiZ" is needed for my cylindrically shaped MPGD detector in ePIC at EIC.
  • The class derives from the "CylindricalSegmentation" class.
  • It reads its "gridSize" parameters the usual way. Optional "offset" parameters, the same.
  • It has an extra type of parameter, viz. "radius", used by the "position" and "cellDimensions" methods, to transform from the phi,Z representation to X,Y.

BEGINRELEASENOTES

  • Adding a "CylindricalGridPhiZ" segmentation class.
    • N.B.: the class has a "radius" data member, registered by the constructors.

ENDRELEASENOTES

andresailer
andresailer reviewed Jul 15, 2024
View reviewed changes
DDCore/include/DD4hep/CylindricalGridPhiZ.h Outdated Show resolved Hide resolved
DDCore/include/DD4hep/CylindricalGridPhiZ.h Outdated Show resolved Hide resolved
DDCore/include/DDSegmentation/CylindricalGridPhiZ.h Outdated Show resolved Hide resolved
DDCore/src/CylindricalGridPhiZ.cpp Outdated Show resolved Hide resolved
DDCore/src/segmentations/CylindricalGridPhiZ.cpp Outdated Show resolved Hide resolved
DDCore/src/segmentations/CylindricalGridPhiZ.cpp Outdated Show resolved Hide resolved
DDCore/src/segmentations/CylindricalGridPhiZ.cpp Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Test Results

   14 files     14 suites   5h 28m 7s ⏱️
  365 tests   365 ✅ 0 💤 0 ❌
2 510 runs  2 510 ✅ 0 💤 0 ❌

Results for commit 9bafcef.

@andresailer andresailer enabled auto-merge (rebase) July 24, 2024 08:13
@andresailer andresailer merged commit c3b305c into AIDASoft:master Jul 24, 2024
13 checks passed
@wdconinc wdconinc mentioned this pull request Jul 24, 2024
Merged
wdconinc added a commit to eic/eic-spack that referenced this pull request Jul 24, 2024
@wdconinc
dd4hep: add PR1294 for 1.29 (#656)
88eb8fc 
### Briefly, what does this PR introduce?
This PR adds AIDASoft/DD4hep#1294 to DD4hep
v1.29.
@wdconinc wdconinc mentioned this pull request Jul 24, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andresailer andresailer andresailer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ybedfer @andresailer