CMake: explicitly ask for ROOTEve component #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ROOT no longer finds nlohmann_json unless we ask for the ROOTEve component, so we ask for the ROOTEve component if the ROOTEve component exists. DDEve and one executable in UtilityApps depend on this
Test Results 14 files 14 suites 5h 44m 47s ⏱️ For more details on these failures, see this check. Results for commit d205ba3. |
|
PS: this is PR 1337 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ROOT no longer finds nlohmann_json unless we ask for the ROOTEve component, so we ask for the ROOTEve component if the ROOTEve component exists. DDEve and one executable in UtilityApps depend on this
cf. root-project/root#16703
BEGINRELEASENOTES
ENDRELEASENOTES