Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read edm4hep #1371

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Read edm4hep #1371

wants to merge 15 commits into from

Conversation

andresailer
Copy link
Member

@andresailer andresailer commented Dec 13, 2024

BEGINRELEASENOTES

ENDRELEASENOTES

Copy link

github-actions bot commented Dec 13, 2024

Test Results

   14 files     14 suites   5h 37m 26s ⏱️
  370 tests   369 ✅ 0 💤 1 ❌
2 539 runs  2 538 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 60603ac.

♻️ This comment has been updated with latest results.

@andresailer andresailer marked this pull request as ready for review December 17, 2024 16:18
@andresailer
Copy link
Member Author

That GeneratorInfo is not yet written to EDM4hep files?

@tmadlener
Copy link
Contributor

That GeneratorInfo is not yet written to EDM4hep files?

Not consistently, i.e. if at all currently only with files that are produced via k4GeneratorsConfig. So I think we have to consider that effectively optional at this point, until that has become more prevalent. Additionally, there are still some changes pending, so maybe we should consider postponing that here in any case?

DDG4/edm4hep/EDM4hepFileReader.cpp Show resolved Hide resolved
DDG4/edm4hep/EDM4hepFileReader.cpp Outdated Show resolved Hide resolved
class EDM4hepFileReader : public Geant4EventReader {
protected:
/// Reference to reader object
podio::ROOTReader m_reader {};
Copy link
Contributor

@tmadlener tmadlener Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
podio::ROOTReader m_reader {};
podio::Reader m_reader;

Would immediately enable support for more backends (most importantly RNTuple, to a lesser extent SIO), without having to do that later.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the file extension convention for sio files?

Copy link
Contributor

@tmadlener tmadlener Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"sio" (as per this check)

DDG4/edm4hep/EDM4hepFileReader.cpp Outdated Show resolved Hide resolved
DDG4/edm4hep/Geant4Output2EDM4hep.cpp Show resolved Hide resolved
DDG4/edm4hep/Geant4Output2EDM4hep.cpp Show resolved Hide resolved
m_directAccess = true;
}

void EDM4hepFileReader::registerRunParameters() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will inadvertently mix "file level" metadata and run parameters for the output, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed it would do that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to keep them separated? E.g. by attaching the metadata frame to some entity as an extension and then writing it out again as a whole in the output if it is present?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create EDM4hep reader for DDG4
2 participants