add compatibility with pathlib.Path to root_io #699
+34
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
reviewed
Oct 23, 2024
Comment on lines
+25
to
+34
| if isinstance(filenames, list): | ||
| str_filenames = [] | ||
| for f in filenames: | ||
| if isinstance(f, (str, Path)): | ||
| str_filenames.append(str(f)) | ||
| else: | ||
| raise TypeError(f"Invalid filename type: {f} (type: {type(f)})") | ||
| return str_filenames | ||
|
|
||
| raise TypeError(f"Invalid filenames argument: {filenames} (type: {type(filenames)})") |
There was a problem hiding this comment.
Can we not simply do
return [str(e) for e in filenames]and the conversion will raise the TypeError for us in case it is not possible to do it?
There was a problem hiding this comment.
Ok. Do you have any objections to using os.fspath instead of str? It is better for catching wrong types, e.g. if None is passed
There was a problem hiding this comment.
If reader.openFiles swallows a list of os.fspath, I have no objections.
There was a problem hiding this comment.
os.fspath() only returns str or bytes. I am unsure what happens if a bytes path is given to reader.openFiles. fspath is just better at throwing TypeError if the argument is not pathlike compared to str(). https://docs.python.org/3/library/os.html#os.fspath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
ENDRELEASENOTES