Got rid off DateOnly converters

AKlaus · Jan 1, 2024 · 66b9dea · 66b9dea
1 parent 8dfb694
commit 66b9dea
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 68 deletions.
diff --git a/Api/Api.csproj b/Api/Api.csproj
@@ -7,8 +7,10 @@
 
 	<ItemGroup>
 		<PackageReference Include="DomainResult" Version="3.2.0" />
-		<PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="8.0.0" />
 		<PackageReference Include="Swashbuckle.AspNetCore" Version="6.5.0" />
+		<!-- The EF references below are required for generating the migration script only -->
+		<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="8.0.0" />
+		<PackageReference Include="Microsoft.EntityFrameworkCore.Design" Version="8.0.0" />
 	</ItemGroup>
 
 	<ItemGroup>

diff --git a/Database/DataContext.cs b/Database/DataContext.cs
@@ -1,5 +1,4 @@
 using AK.DbSample.Database.Entities;
-using AK.DbSample.Database.Infrastructure;
 
 using Microsoft.EntityFrameworkCore;
 
@@ -20,8 +19,7 @@ protected override void OnModelCreating(ModelBuilder modelBuilder)
 			{
 				// Date is a DateOnly property and date on database
 				builder.Property(x => x.Date)
-					// These converters are still required in EF 7 (https://github.com/dotnet/efcore/issues/24507)
-					.HasConversion<DateOnlyConverter, DateOnlyComparer>();
+					   .HasColumnType("date");
 
 				// Set cascade delete
 				builder.HasOne(p => p.Client)

diff --git a/Database/Infrastructure/DateOnlyComparer.cs b/Database/Infrastructure/DateOnlyComparer.cs
diff --git a/Database/Infrastructure/DateOnlyConverter.cs b/Database/Infrastructure/DateOnlyConverter.cs
diff --git a/Database/Migrations/20220322114144_InititalCreate.cs b/Database/Migrations/20220322114144_InititalCreate.cs
@@ -28,7 +28,7 @@ protected override void Up(MigrationBuilder migrationBuilder)
                 {
                     Number = table.Column<string>(type: "nvarchar(100)", nullable: false),
                     ClientId = table.Column<long>(type: "bigint", nullable: false),
-                    Date = table.Column<DateTime>(type: "datetime", nullable: false),
+                    Date = table.Column<DateOnly>(type: "date", nullable: false),
                     Amount = table.Column<decimal>(type: "decimal(18,2)", nullable: false)
                 },
                 constraints: table =>