Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equally divide analog stick to 8 parts #107

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Skirlez
Copy link

@Skirlez Skirlez commented Oct 26, 2021

(This is my first code pull request; I'm not really sure if this is what I should do/how this works)

As it is currently, the analog stick is very biased towards diagonal directions, and it's very hard to aim forward/up/down. This fixes the issue by dividing the stick to 8 parts, one for each direction.

stickAngle gets the angle of the stick with point_direction()
check stickAngle and determine if it is within what would be considered that direction
@Lojemiru
Copy link
Collaborator

Lojemiru commented Oct 26, 2021

Hi! We really appreciate this PR, as analog control is pretty wacky and this is a great idea to improve it. However, we're not currently accepting PRs as we're working on version 2.0 (art overhaul) in a private codebase, and do not intend to release any versions between 1.5.5 and then barring game-breaking bugfixes due to how complex releases and diverging codebases are to manage.

If we end up needing to make a release 1.5.6, we'll definitely look at adding this then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants