Handle reserved names during code-printing #2483
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid symbolic replacements for handling reserved symbols in amici. Instead, only handle them during code printing. This has the advantage that users won't be bothered by changed IDs. This, however, makes it a breaking change for anybody currently relying on "amici_*" entity IDs. I don't expect this to be much of a problem, since probably most users would have renamed their model entities to avoid this "amici_"-prefixing. Fixes AMICI-dev#2461.
|
This won't work for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid symbolic replacements for handling reserved symbols in amici.
Instead, only handle them during code printing. This has the advantage that
users won't be bothered by changed IDs.
This, however, makes it a breaking change for anybody currently relying on "amici_*" entity IDs.
I don't expect this to be much of a problem, since probably most users would have renamed their model
entities to avoid this "amici_"-prefixing.
Fixes #2461.