Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

for true SDC, remove sdc_solve_for_rhoe option #2555

Closed
wants to merge 3 commits into from
Closed

for true SDC, remove sdc_solve_for_rhoe option #2555

wants to merge 3 commits into from

Conversation

zingale
Copy link
Member

@zingale zingale commented Sep 17, 2023

we always do this, as solving for the kinetic energy seems more toublesome

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
for true SDC, remove sdc_solve_for_rhoe option
1430a9f 
we always do this, as solving for the kinetic energy seems more
toublesome
@zingale zingale added the sdc label Sep 17, 2023
@zingale zingale changed the title [WIP] for true SDC, remove sdc_solve_for_rhoe option for true SDC, remove sdc_solve_for_rhoe option Sep 18, 2023
@zingale
Copy link
Member Author

zingale commented Sep 18, 2023

all tests pass: http://groot.astro.sunysb.edu/Castro/test-suite/gfortran/2023-09-18-002/index.html

@zingale
Copy link
Member Author

zingale commented Sep 20, 2023

I've merged this into #2560

@zingale zingale closed this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
sdc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zingale