Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert correct_dterm to C++ #2620

Merged
merged 4 commits into from
Oct 10, 2023

Conversation

maxpkatz
Copy link
Member

@maxpkatz maxpkatz commented Oct 9, 2023

PR summary

This uses inline metric calculation to support GPU offloading. Note that the vector s was unused and was previously only in the code to enable the call to sphe to fill in re for spherical geometries, which is now handled through edge_center_metric if we're in a spherical geometry. We also do a loop over dimensions to make the code a little more understandable.

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale
Copy link
Member

zingale commented Oct 9, 2023

@maxpkatz maxpkatz marked this pull request as ready for review October 9, 2023 21:19
@zingale zingale merged commit 22d6158 into AMReX-Astro:development Oct 10, 2023
18 checks passed
@maxpkatz maxpkatz deleted the cxx-correct-dterm branch October 10, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants