Convert hdterm and hdterm3 to C++ #2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there's a crash in the test suite for rad-thermalwave-3d |
|
compliation failure actually |
fixed |
zingale
reviewed
Oct 10, 2023
| { | ||
| if (mask.contains(i+icp,j+jcp,k+kcp)) { | ||
| if (mask(i+icp,j+jcp,k+kcp) > 0) { | ||
| if (bct == LO_DIRICHLET) { |
There was a problem hiding this comment.
do we want to throw an error if they come in with the wrong boundary type? That's the only real diff with the Fortran
zingale
reviewed
Oct 10, 2023
| // group is for cell edges. | ||
|
|
||
| int icp = 0; | ||
| int jcp = 0; |
There was a problem hiding this comment.
we have this same code now in several places.. Maybe we should make an inline function with this and return things via structured binding? Doesn't need to be this PR
There was a problem hiding this comment.
Yes, one of my plans after we finish the Fortran conversion is to do a bunch of cleanup on this since there's a bunch of similar-ish functions across the three Hypre ABEC implementations
zingale
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
PR checklist
CHANGESfile has been updated, if appropriate