Compute the shock flag once -- at the start of the timestep #2728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it should not matter which comes first, since reactions don't change density, but this swap will allow us to precompute the shock flag with sources before the first burn.
…new_shock_flag_call
zingale
changed the title
|
this is ready for review now |
yut23
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR summary
This changes the way the shock flag is computed for disabling burning in shocks. Now we compute it
at the top of the timestep, before the first Strang burn, using the time-level n state and sources.
There is some redundancy here (we need to compute the old sources before the burn now),
and there is a FillPatch needed. But this should be minimal and only in effect if we compile with SHOCK_VAR.
Note: this does not change how we compute the shock flag for hydro at the moment
when doing the hybrid Riemann solve (although we can easily change that in a future PR).
PR motivation
PR checklist
CHANGESfile has been updated, if appropriate