Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update source_flag to work with spherical and allow geometric source terms for 1d spherical #2993

Open
wants to merge 4 commits into
base: development
Choose a base branch
from
Open

update source_flag to work with spherical and allow geometric source terms for 1d spherical #2993

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6766e37
update apply_source flag and add geometric source terms for 1d spherical
zhichen3 Nov 13, 2024
d33da16
Merge branch 'development' into fix_geom_source_flag
zhichen3 Nov 13, 2024
abf1a66
Merge branch 'development' into fix_geom_source_flag
zingale Nov 17, 2024
1ef1731
Merge branch 'development' into fix_geom_source_flag
zingale Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Source/sources/Castro_geom.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Castro::construct_old_geom_source(MultiFab& source, MultiFab& state_in, Real tim
return;
}

#if AMREX_SPACEDIM == 2
#if AMREX_SPACEDIM <= 2
const Real strt_time = ParallelDescriptor::second();

MultiFab geom_src(grids, dmap, source.nComp(), 0);
Expand Down Expand Up @@ -83,7 +83,7 @@ Castro::construct_new_geom_source(MultiFab& source, MultiFab& state_old,
return;
}

#if AMREX_SPACEDIM == 2
#if AMREX_SPACEDIM <= 2
const Real strt_time = ParallelDescriptor::second();

MultiFab geom_src(grids, dmap, source.nComp(), 0);
Expand Down
6 changes: 3 additions & 3 deletions Source/sources/Castro_sources.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,10 +61,10 @@ Castro::source_flag(int src)
#endif

case geom_src:
if (geom.Coord() == 1) {
return true;
} else {
if (geom.Coord() == 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there aren't any geometry sources for 1-d spherical or cylindrical either, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it depends on what does 1d spherical mean exactly. Are we assuming purely 1d with velocities in theta and phi direction being 0 or are we assuming 3d but with theta and phi symmetry?

return false;
} else {
return true;
}

#ifdef DIFFUSION
Expand Down
Loading