Skip to content

Commit

Permalink
Update for Microphysics EXTRA_THERMO change (#393)
Browse files Browse the repository at this point in the history
We now use the new structs added in AMReX-Astro/Microphysics#1229.
  • Loading branch information
maxpkatz authored Jun 19, 2023
1 parent be655eb commit 271cff6
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 18 deletions.
7 changes: 0 additions & 7 deletions Exec/Make.Maestro
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,6 @@ all: $(executable)
# Maestro uses a coarse grained OMP approach
DEFINES += -DCRSEGRNDOMP

# Maestro needs to compute additional thermodynamic derivatives in the EOS
DEFINES += -DEXTRA_THERMO

USE_MG = FALSE

ifeq ($(DIM), 1)
Expand Down Expand Up @@ -125,10 +122,6 @@ USE_CXX_REACTIONS := TRUE

ifeq ($(USE_REACT), TRUE)
DEFINES += -DREACTIONS
ifeq ($(USE_SDC), TRUE)
# we need the compositional derivatives for SDC
DEFINES += -DEXTRA_THERMO
endif
endif

# Maestro SDC uses the SDC_EVOLVE_ENTHALPY mode in StarKiller Microphysics
Expand Down
4 changes: 0 additions & 4 deletions Exec/science/urca/analysis/GNUmakefile
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,6 @@ ifdef NEED_EOS_NETWORK

endif

# Add EXTRA_THERMO to FPP_DEFINES to calculate dpdA, etc.
EXTRA_THERMO := t
FPP_DEFINES += -DEXTRA_THERMO=$(EXTRA_THERMO)

# we are not using the CUDA stuff
FPP_DEFINES += -DAMREX_DEVICE=""

Expand Down
4 changes: 2 additions & 2 deletions Exec/test_problems/imposed_external_heating/MaestroMakeS.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ void Maestro::Make_S_cc(
const Array4<const Real> normal_arr = normal[lev].array(mfi);

AMREX_PARALLEL_FOR_3D(tileBox, i, j, k, {
eos_t eos_state;
eos_extra_t eos_state;

eos_state.rho = scal_arr(i, j, k, Rho);
eos_state.T = scal_arr(i, j, k, Temp);
Expand Down Expand Up @@ -199,7 +199,7 @@ void Maestro::Make_S_cc(
base_geom.anelastic_cutoff_density_coord(lev);

AMREX_PARALLEL_FOR_3D(tileBox, i, j, k, {
eos_t eos_state;
eos_extra_t eos_state;

eos_state.rho = scal_arr(i, j, k, Rho);
eos_state.T = scal_arr(i, j, k, Temp);
Expand Down
2 changes: 1 addition & 1 deletion Source/MaestroIntra.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ void Maestro::MakeIntraCoeffs(const Vector<MultiFab>& scal1,

ParallelFor(gtbx, [=] AMREX_GPU_DEVICE(int i, int j, int k) {
// old state first
eos_t eos_state;
eos_extra_t eos_state;

eos_state.rho = scalold(i, j, k, Rho);
eos_state.T = scalold(i, j, k, Temp);
Expand Down
4 changes: 2 additions & 2 deletions Source/MaestroMakeS.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ void Maestro::Make_S_cc(
const Array4<const Real> normal_arr = normal[lev].array(mfi);

ParallelFor(tileBox, [=] AMREX_GPU_DEVICE(int i, int j, int k) {
eos_t eos_state;
eos_extra_t eos_state;

eos_state.rho = scal_arr(i, j, k, Rho);
eos_state.T = scal_arr(i, j, k, Temp);
Expand Down Expand Up @@ -199,7 +199,7 @@ void Maestro::Make_S_cc(
base_geom.anelastic_cutoff_density_coord(lev);

ParallelFor(tileBox, [=] AMREX_GPU_DEVICE(int i, int j, int k) {
eos_t eos_state;
eos_extra_t eos_state;

eos_state.rho = scal_arr(i, j, k, Rho);
eos_state.T = scal_arr(i, j, k, Temp);
Expand Down
2 changes: 1 addition & 1 deletion Source/MaestroThermal.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ void Maestro::MakeThermalCoeffs(const Vector<MultiFab>& scal,
Xkcoeff_arr(i, j, k, comp) = 0.0;
}
} else {
eos_t eos_state;
eos_extra_t eos_state;
eos_state.rho = scal_arr(i, j, k, Rho);
eos_state.T = scal_arr(i, j, k, Temp);
for (auto comp = 0; comp < NumSpec; ++comp) {
Expand Down
2 changes: 1 addition & 1 deletion external/Microphysics
Submodule Microphysics updated 97 files
+16 −0 .github/workflows/burn_cell.yml
+31 −2 .github/workflows/burn_cell_primordial_chem.yml
+91 −0 .github/workflows/castro.yml
+2 −2 .github/workflows/cuda.yml
+21 −0 .github/workflows/dependencies/dependencies.sh
+11 −0 .github/workflows/dependencies/dependencies_ccache.sh
+0 −0 .github/workflows/dependencies/dependencies_hip.sh
+0 −0 .github/workflows/dependencies/dependencies_nvcc11.sh
+0 −3 .github/workflows/good_defines.txt
+1 −1 .github/workflows/hip.yml
+0 −1 .github/workflows/macos_build_cell_primordial_chem.yml
+7 −0 CHANGES.md
+2 −42 CMakeLists.txt
+11 −5 EOS/eos_composition.H
+17 −17 EOS/gamma_law/actual_eos.H
+62 −88 EOS/helmholtz/actual_eos.H
+6 −4 EOS/multigamma/actual_eos.H
+0 −2 EOS/multigamma/eos_composition.H
+6 −4 EOS/polytrope/actual_eos.H
+0 −2 EOS/primordial_chem/eos_composition.H
+6 −4 EOS/ztwd/actual_eos.H
+0 −11 Make.Microphysics_extern
+13 −3 integration/BackwardEuler/actual_integrator.H
+5 −2 integration/BackwardEuler/actual_integrator_simplified_sdc.H
+31 −120 integration/BackwardEuler/be_integrator.H
+3 −4 integration/BackwardEuler/be_type.H
+10 −5 integration/ForwardEuler/actual_integrator.H
+19 −11 integration/QSS/actual_integrator.H
+4 −0 integration/RKC/_parameters
+18 −6 integration/RKC/actual_integrator.H
+7 −23 integration/RKC/actual_integrator_simplified_sdc.H
+58 −234 integration/RKC/rkc.H
+15 −16 integration/RKC/rkc_type.H
+14 −2 integration/VODE/actual_integrator.H
+4 −18 integration/VODE/actual_integrator_simplified_sdc.H
+10 −7 integration/VODE/vode_dvhin.H
+11 −10 integration/VODE/vode_dvjac.H
+8 −5 integration/VODE/vode_dvjust.H
+14 −13 integration/VODE/vode_dvnlsd.H
+15 −14 integration/VODE/vode_dvode.H
+2 −3 integration/VODE/vode_dvset.H
+42 −39 integration/VODE/vode_dvstep.H
+14 −20 integration/VODE/vode_type.H
+4 −0 integration/_parameters
+2 −1 integration/integrator.H
+26 −0 integration/integrator_data.H
+5 −5 integration/integrator_rhs_simplified_sdc.H
+16 −4 integration/integrator_rhs_strang.H
+12 −90 integration/integrator_type_simplified_sdc.H
+18 −6 integration/integrator_type_strang.H
+182 −23 integration/nse_update_simplified_sdc.H
+2 −1 integration/nse_update_strang.H
+3 −0 integration/utils/Make.package
+35 −0 integration/utils/circle_theorem.H
+98 −0 integration/utils/initial_timestep.H
+2 −1 integration/utils/jacobian_utilities.H
+4 −2 integration/utils/nonaka_plot.H
+39 −13 integration/utils/numerical_jacobian.H
+211 −0 integration/utils/rkc_util.H
+13 −46 interfaces/burn_type.H
+2 −1 interfaces/burner.H
+5 −3 interfaces/eos.H
+86 −22 interfaces/eos_type.H
+2 −2 networks/ase/_parameters
+200 −206 networks/ase/actual_network.H
+517 −544 networks/ase/actual_rhs.H
+ networks/ase/ase.png
+12 −1 networks/ase/ase.py
+120 −120 networks/ase/partition_functions.H
+537 −710 networks/ase/reaclib_rates.H
+ networks/ase/subch_simple.png
+28 −11 nse_solver/nse_check.H
+29 −19 nse_solver/nse_solver.H
+14 −1 sphinx_docs/source/integrators.rst
+4 −0 unit_test/burn_cell/burn_cell.H
+72 −0 unit_test/burn_cell/ci-benchmarks/aprox13_RKC_unit_test.out
+4 −2 unit_test/burn_cell_primordial_chem/CMakeLists.txt
+477 −0 unit_test/burn_cell_primordial_chem/reference_solution.out
+0 −3 unit_test/burn_cell_sdc/GNUmakefile
+1 −8 unit_test/burn_cell_sdc/burn_cell.H
+0 −2 unit_test/test_aprox_rates/GNUmakefile
+2 −2 unit_test/test_aprox_rates/aprox_rates_util.cpp
+2 −0 unit_test/test_ase/burn_cell.H
+2 −0 unit_test/test_ase/make_table/burn_cell.H
+0 −2 unit_test/test_conductivity/GNUmakefile
+1 −1 unit_test/test_conductivity/conductivity_util.cpp
+0 −2 unit_test/test_eos/GNUmakefile
+2 −2 unit_test/test_eos/eos_util.cpp
+0 −2 unit_test/test_jac/GNUmakefile
+1 −1 unit_test/test_jac/jac_zones.H
+0 −2 unit_test/test_screening/GNUmakefile
+0 −3 unit_test/test_sdc/GNUmakefile
+1 −1 unit_test/test_sdc/main.cpp
+1 −16 unit_test/test_sdc/react_zones.H
+0 −3 unit_test/test_sdc_vode_rhs/GNUmakefile
+1 −12 unit_test/test_sdc_vode_rhs/vode_rhs_test.H
+2 −2 util/build_scripts/write_probin.py

0 comments on commit 271cff6

Please sign in to comment.