Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CI to check the runtime parameters #460

Merged
merged 15 commits into from
May 16, 2024
Merged

add CI to check the runtime parameters #460

merged 15 commits into from
May 16, 2024

Conversation

zingale
Copy link
Member

@zingale zingale commented May 16, 2024

We look at all of the maestro.X parameters in any inputs* file and make sure they
legitimate parameters defined in _cpp_parameters.

Also fix a bunch of mistakes and more some old SDC remnants.

This is based off of the Castro check.

@zingale zingale requested a review from biboyd May 16, 2024 14:51
biboyd
biboyd reviewed May 16, 2024
View reviewed changes
Copy link
Collaborator

@biboyd biboyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just some cleanup of some comments

.github/workflows/check_params.py Outdated Show resolved Hide resolved
Exec/science/flame/inputs_2d_smallscale Outdated Show resolved Hide resolved
Exec/science/flame/inputs_2d_smallscale.2levels Outdated Show resolved Hide resolved
Exec/science/flame/inputs_2d_smallscale.testsuite Outdated Show resolved Hide resolved
Exec/science/flame/inputs_3d_smallscale Outdated Show resolved Hide resolved
Exec/science/flame/inputs_3d_smallscale.testsuite Outdated Show resolved Hide resolved
Exec/science/sub_chandra/inputs_3d Outdated Show resolved Hide resolved
Exec/science/toy_convect/inputs_2d Outdated Show resolved Hide resolved
Exec/science/xrb_layered/inputs Outdated Show resolved Hide resolved
Exec/science/xrb_mixed/inputs_2d.rprox Outdated Show resolved Hide resolved
zingale and others added 11 commits May 16, 2024 13:57
@zingale @biboyd
Update .github/workflows/check_params.py
dca1ed9 
Co-authored-by: Brendan Boyd <[email protected]>
@zingale @biboyd
Update Exec/science/flame/inputs_2d_smallscale.2levels
4a8a2cf 
Co-authored-by: Brendan Boyd <[email protected]>
@zingale @biboyd
Update Exec/science/flame/inputs_2d_smallscale
857305f 
Co-authored-by: Brendan Boyd <[email protected]>
@zingale @biboyd
Update Exec/science/flame/inputs_2d_smallscale.testsuite
6345970 
Co-authored-by: Brendan Boyd <[email protected]>
@zingale @biboyd
Update Exec/science/flame/inputs_3d_smallscale
cdaecfe 
Co-authored-by: Brendan Boyd <[email protected]>
@zingale @biboyd
Update Exec/science/sub_chandra/inputs_3d
8691c82 
Co-authored-by: Brendan Boyd <[email protected]>
@zingale @biboyd
Update Exec/science/flame/inputs_3d_smallscale.testsuite
bd830df 
Co-authored-by: Brendan Boyd <[email protected]>
@zingale @biboyd
Update Exec/science/toy_convect/inputs_2d
768cab2 
Co-authored-by: Brendan Boyd <[email protected]>
@zingale @biboyd
Update Exec/science/xrb_layered/inputs
80445aa 
Co-authored-by: Brendan Boyd <[email protected]>
@zingale @biboyd
Update Exec/science/xrb_mixed/inputs_2d.rprox
eb940e1 
Co-authored-by: Brendan Boyd <[email protected]>
@biboyd
Merge branch 'development' into fix_params
ebf08c6
@biboyd biboyd merged commit 57c2302 into AMReX-Astro:development May 16, 2024
10 checks passed
@zingale zingale deleted the fix_params branch May 16, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@biboyd biboyd biboyd left review comments

Assignees
No one assigned
Labels
test coversage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @biboyd