[WIP] implement scale_system for simplified-SDC #1241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
one issue I need to be careful with is that for the Jacobian, when we do: d(rho omegadot)/(d rho X) we are actually expressing this as domegadot/dX, so there is no density scaling. But for the integrator, we are scaling by the initial density, rho_0, so perhaps we need to correct these terms with a (rho / rho_0) factor? |
basically, once we convert back from the integrator type to the burn_t, we should not have to use the integrator type any more. This will make it easier to merge these code paths in the future.
we don't need int_state
…to sdc_scale_system
we come in with a valid e this syncs us up with VODE
…to sdc_scale_system
Signed-off-by: Michael Zingale <[email protected]>
…to sdc_scale_system
|
closing in favor of the simpler #1253 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in addition to scaling energy, we now also need to scale density, since we are integrating (rho X, rho e)