-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pynucastro networks #1287
Update pynucastro networks #1287
Conversation
Also add a python script to do this with a single command.
Going to wait for pynucastro/pynucastro#580 to be merged |
Along with #1287, this resolves all the remaining warnings I could find with burn_cell and test_rhs.
do we want to wait until we do the PR that changes the interpolation for tables to work on logs? |
Not sure. What do the tests look like now? |
I'm not sure I understand. We haven't implemented that yet. So once we do implement the proper interpolation, we'd want to regenerate these again. |
Oh, I see. I was wondering if that would give bigger diffs on the regression tests. I think the Suzuki table updates are the only thing that would change the results in this PR right now. |
I was trying to build subchandra with CUDA on perlmutter with updated network, but it seems like it's complaining that
I also tried on groot, getting the same error, but I do see the |
That's unfortunate, we can probably just write a manual binary search instead (or maybe reuse |
we do compile test_react with subch_simple in the cuda test though? |
Yes, but Microphysics/networks/subch_simple/partition_functions.H Lines 66 to 81 in eb5189f
|
ah okay. We could build with |
Yeah, that would be good since it exercises approximate rates too. |
with the release of pynucastro 2.1.0, I think we are ready for this now. We should update to get the latest table changes. |
I think we need to update some benchmarks now |
Regenerated from the current pynucastro
main
branch: pynucastro/pynucastro@556584d.Also add a python script to do this with a single command.